Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More dup lookup fixes #5484

Closed
wants to merge 5 commits into from
Closed

More dup lookup fixes #5484

wants to merge 5 commits into from

Conversation

realbigsean
Copy link
Member

@realbigsean realbigsean commented Mar 26, 2024 •
edited
Loading

Issue Addressed

  • add logs
  • tighten up lookup de-duplication logic
  • an alternative fix to: Fix unexpected UnrequestedBlobId and ExtraBlocksReturned errors due to race conditions. #5477
    • the core issue in the bug there is that we update requested_ids while blobs are still downloading if we download the RPC block in between blobs of the stream. this becomes and issue because requested_ids is updated with any blobs that come via gossip.
    • proposed solution here is to only update the blobs if the request state is AwaitingDownload which means it has been either completed or not yet started

@realbigsean realbigsean added ready-for-review The code is ready for review bug Something isn't working deneb v5.2.0 Q2 2024 labels Mar 26, 2024
@realbigsean realbigsean mentioned this pull request Mar 26, 2024
Merged
@realbigsean
Copy link
Member Author

closing in favor of #5488

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working deneb ready-for-review The code is ready for review v5.2.0 Q2 2024
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@realbigsean