-
Notifications
You must be signed in to change notification settings - Fork 747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use portable
builds by default
#5489
Conversation
Succesful CI runs (on subpar runners so timings aren't accurate): |
Michael has already run some benchmarks next step would be for us to dogfood this and deploy |
I'm ok with rolling it out. I was hesitant previously because the benchmarks showed a slight detriment, but we should gather some data on what impact this small slowdown has on the real workload |
I'm onboard to try it out 👍 |
We have portable builds running on our own fleet now, up to and including canaries, while mainnet runs the canonical non-portable release. |
I support this change also (under the believe that Michael's performance metrics show no real/significant performance degradation) |
Issue Addressed
Heavily reduces strain on CI infra during docker builds and releases
(docker builds: 9 -> 4* ; release builds 8 -> 4)
See #5457
Proposed Changes
Make
blst-portable
the default across the board and stop offeringforce-adx
buildsAdditional Info
In this PR, all current docker tags and direct release links** are preserved but lead to a
portable
build instead, which should work for everyone.The idea is to release with these placeholders to try and assess how many downloads we still get on the to-be-deprecated release links.
Before we consider this, we should make absolutely sure that the performance hit, if present, is negligible on modern hardware.
(* 8 lighthouse and 1 lcli build --> 2 lighthouse and 2 lcli builds)
(** excluding the link for a non-portable windows build)
Summary of changes
blst
librarylcli
is built throughcross
, and published as multiplatform imagespec-minimal