web3Signer: set header "Accept: application/json" as we expect json in the response #5692

lrusak · 2024-05-02T05:30:11Z

Issue Addressed

Proposed Changes

This PR sets the request header for the web3signer to Accept: application/json. This is required to indicate to a remote signer that json is the acceptable return type (instead of plain/text)

Additional Info

the web3signer api indicates that both application/json and text/plain are acceptable response types for signing requests.

The web3signer handler in lighthouse requires a json response. Setting the header "Accept: application/json" indicates to the web3signer that json is an acceptable response.

…n the response The web3signer handler in lighthouse requires a json response. Setting the header "Accept: application/json" indicates to the web3signer that json is an acceptable response. Signed-off-by: Lukas Rusak <lorusak@gmail.com>

CLAassistant · 2024-05-02T05:33:13Z

All committers have signed the CLA.

michaelsproul · 2024-05-02T05:57:29Z

Nice find, thanks!

If you don't mind filling in the contributor agreement, we can get this merged soon!

lrusak · 2024-05-02T15:27:34Z

Nice find, thanks!

If you don't mind filling in the contributor agreement, we can get this merged soon!

Signed 😊

… json in the response

lrusak · 2024-05-02T22:55:56Z

I pushed a fixup to make the ci happy

michaelsproul · 2024-05-03T00:35:14Z

thanks, will merge once CI passes

lrusak · 2024-05-03T00:44:28Z

thanks, will merge once CI passes

It looks like there are a couple unrelated failures. Should I just squash the fixup?

michaelsproul · 2024-05-03T01:04:25Z

Don't worry about it, I'll merge your PR in a batch with this one which should fix the Clippy failure:

Improve logging and metrics for block publication #5699

michaelsproul · 2024-05-03T01:04:47Z

Some of the other failures (the Windows one) are just flakiness. I'll kick the CI server to get it to try harder 🤣

michaelsproul · 2024-05-03T01:49:09Z

@Mergifyio queue

mergify · 2024-05-03T01:49:23Z

queue

🛑 Command `queue` cancelled because of a new `queue` command with different arguments

…n the response (#5692) Squashed commit of the following: commit 92f5ad0 Author: Lukas Rusak <lorusak@gmail.com> Date: Thu May 2 15:53:58 2024 -0700 fixup! web3Signer: set header "Accept: application/json" as we expect json in the response commit 8965009 Author: Lukas Rusak <lorusak@gmail.com> Date: Wed May 1 21:16:27 2024 -0700 web3Signer: set header "Accept: application/json" as we expect json in the response The web3signer handler in lighthouse requires a json response. Setting the header "Accept: application/json" indicates to the web3signer that json is an acceptable response. Signed-off-by: Lukas Rusak <lorusak@gmail.com>

michaelsproul · 2024-05-03T02:16:31Z

@Mergifyio requeue

mergify · 2024-05-03T02:16:38Z

requeue

❌ This pull request head commit has not been previously disembarked from queue.

michaelsproul · 2024-05-03T04:26:19Z

@Mergifyio requeue

mergify · 2024-05-03T04:26:26Z

requeue

❌ This pull request head commit has not been previously disembarked from queue.

jimmygchen · 2024-05-03T06:02:37Z

@mergify queue

mergify · 2024-05-03T06:02:45Z

queue

🛑 The pull request has been removed from the queue `default`

Pull request #5692 has been dequeued by a dequeue command.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

jimmygchen · 2024-05-03T06:47:31Z

@mergify unqueue

mergify · 2024-05-03T06:47:52Z

unqueue

✅ The pull request has been removed from the queue `default`

jimmygchen · 2024-05-03T09:27:03Z

@mergify queue

mergify · 2024-05-03T09:27:16Z

queue

🛑 The pull request has been removed from the queue `default`

Pull request #5692 has been dequeued by a dequeue command.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

lrusak · 2024-05-03T17:59:18Z

Anything else I can help out with here?

jimmygchen · 2024-05-03T21:59:42Z

@mergify queue

mergify · 2024-05-03T21:59:48Z

queue

🛑 The pull request has been removed from the queue `default`

Pull request #5692 has been dequeued by a dequeue command.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

michaelsproul · 2024-05-05T23:09:51Z

@Mergifyio requeue

mergify · 2024-05-05T23:09:58Z

requeue

✅ This pull request will be re-embarked automatically

The followup queue command will be automatically executed to re-embark the pull request

mergify · 2024-05-05T23:09:58Z

queue

🛑 The pull request has been removed from the queue `default`

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

michaelsproul · 2024-05-05T23:49:53Z

Sorry, our CI seems to be particularly flaky.

michaelsproul · 2024-05-05T23:50:01Z

@Mergifyio requeue

mergify · 2024-05-05T23:50:08Z

requeue

✅ This pull request will be re-embarked automatically

The followup queue command will be automatically executed to re-embark the pull request

mergify · 2024-05-05T23:50:09Z

queue

🛑 The pull request has been removed from the queue `default`

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

michaelsproul · 2024-05-06T02:27:13Z

https://github.com/Mergifyio requeue

mergify · 2024-05-06T02:27:21Z

requeue

✅ This pull request will be re-embarked automatically

The followup queue command will be automatically executed to re-embark the pull request

mergify · 2024-05-06T02:27:22Z

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at da9d386

lrusak · 2024-06-01T20:01:02Z

Can this be included in #5664?

michaelsproul · 2024-06-01T23:53:54Z

@lrusak it already is

lrusak · 2024-06-02T14:01:17Z

@lrusak it already is

Hmm ok, I thought I saw it in there before but now I don't see the commit there and I don't see the change in the change list. Maybe it got dropped accidentally?

michaelsproul · 2024-06-02T22:26:53Z

@lrusak Your PR got merged to unstable. The v5.2.0 PR just shows new commits on top of unstable. If you do a git log on that branch you'll see it

lrusak · 2024-06-03T03:20:09Z

@lrusak Your PR got merged to unstable. The v5.2.0 PR just shows new commits on top of unstable. If you do a git log on that branch you'll see it

ah ok, sorry for the noise!

michaelsproul added the waiting-on-author The reviewer has suggested changes and awaits thier implementation. label May 2, 2024

fixup! web3Signer: set header "Accept: application/json" as we expect…

92f5ad0

… json in the response

michaelsproul added ready-for-review The code is ready for review low-hanging-fruit Easy to resolve, get it before someone else does! v5.2.0 Q2 2024 and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels May 3, 2024

michaelsproul added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels May 3, 2024

michaelsproul mentioned this pull request May 3, 2024

Release v5.2.0 #5664

Merged

jimmygchen approved these changes May 3, 2024

View reviewed changes

mergify bot added a commit that referenced this pull request May 3, 2024

Merge of #5692

f374f08

mergify bot mentioned this pull request May 3, 2024

merge queue: embarking unstable (ee974db) and [#5699 + #5692] together #5702

Closed

6 tasks

mergify bot added a commit that referenced this pull request May 5, 2024

Merge of #5692

80bc733

mergify bot mentioned this pull request May 5, 2024

merge queue: embarking unstable (1af3f0f) and #5692 together #5716

Closed

5 tasks

mergify bot added a commit that referenced this pull request May 5, 2024

Merge of #5692

d48e49f

mergify bot mentioned this pull request May 5, 2024

merge queue: embarking unstable (1af3f0f) and #5692 together #5717

Closed

5 tasks

mergify bot added a commit that referenced this pull request May 6, 2024

Merge of #5692

d8bf15c

mergify bot mentioned this pull request May 6, 2024

merge queue: embarking unstable (fe20ef9) and #5692 together #5719

Closed

5 tasks

mergify bot merged commit da9d386 into sigp:unstable May 6, 2024
24 of 27 checks passed

michaelsproul mentioned this pull request Oct 18, 2024

web3signer doesn't set appropriate headers to indicate that json is an acceptable response #5691

Closed

web3Signer: set header "Accept: application/json" as we expect json in the response #5692

web3Signer: set header "Accept: application/json" as we expect json in the response #5692

Conversation

lrusak commented May 2, 2024

Issue Addressed

Proposed Changes

Additional Info

CLAassistant commented May 2, 2024 • edited Loading

michaelsproul commented May 2, 2024

lrusak commented May 2, 2024

lrusak commented May 2, 2024

michaelsproul commented May 3, 2024

lrusak commented May 3, 2024

michaelsproul commented May 3, 2024

michaelsproul commented May 3, 2024

michaelsproul commented May 3, 2024

mergify bot commented May 3, 2024 • edited Loading

🛑 Command queue cancelled because of a new queue command with different arguments

michaelsproul commented May 3, 2024

mergify bot commented May 3, 2024

❌ This pull request head commit has not been previously disembarked from queue.

michaelsproul commented May 3, 2024

mergify bot commented May 3, 2024

❌ This pull request head commit has not been previously disembarked from queue.

jimmygchen commented May 3, 2024

mergify bot commented May 3, 2024 • edited Loading

🛑 The pull request has been removed from the queue default

jimmygchen commented May 3, 2024

mergify bot commented May 3, 2024

✅ The pull request has been removed from the queue default

jimmygchen commented May 3, 2024

mergify bot commented May 3, 2024

🛑 The pull request has been removed from the queue default

lrusak commented May 3, 2024

jimmygchen commented May 3, 2024

mergify bot commented May 3, 2024

🛑 The pull request has been removed from the queue default

michaelsproul commented May 5, 2024

mergify bot commented May 5, 2024

✅ This pull request will be re-embarked automatically

mergify bot commented May 5, 2024 • edited Loading

🛑 The pull request has been removed from the queue default

michaelsproul commented May 5, 2024

michaelsproul commented May 5, 2024

mergify bot commented May 5, 2024

✅ This pull request will be re-embarked automatically

mergify bot commented May 5, 2024 • edited Loading

🛑 The pull request has been removed from the queue default

michaelsproul commented May 6, 2024

mergify bot commented May 6, 2024

✅ This pull request will be re-embarked automatically

mergify bot commented May 6, 2024 • edited Loading

✅ The pull request has been merged automatically

lrusak commented Jun 1, 2024

michaelsproul commented Jun 1, 2024

lrusak commented Jun 2, 2024

michaelsproul commented Jun 2, 2024

lrusak commented Jun 3, 2024

CLAassistant commented May 2, 2024 •

edited

Loading

mergify bot commented May 3, 2024 •

edited

Loading

🛑 Command `queue` cancelled because of a new `queue` command with different arguments

mergify bot commented May 3, 2024 •

edited

Loading

🛑 The pull request has been removed from the queue `default`

✅ The pull request has been removed from the queue `default`

🛑 The pull request has been removed from the queue `default`

🛑 The pull request has been removed from the queue `default`

mergify bot commented May 5, 2024 •

edited

Loading

🛑 The pull request has been removed from the queue `default`

mergify bot commented May 5, 2024 •

edited

Loading

🛑 The pull request has been removed from the queue `default`

mergify bot commented May 6, 2024 •

edited

Loading