-
Notifications
You must be signed in to change notification settings - Fork 743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consistent logging of full root in lookup debug logs #5700
Conversation
1eab61e
to
1b855bf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
beacon_node/network/src/sync/block_lookups/single_block_lookup.rs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvements! I've just got a question above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 👍
@mergify queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 436d54e |
Declaring the service two times does not overwrite the label, but log it twice. Not sure if this is the intended behavior. Elastic search can deal with it fine, as |
Issue Addressed
From offline discussions:
I think we should aim for consistency either way. sean proposed:
Proposed Changes