Bound lookup parent chain length with tip extension #5705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dapplion
force-pushed
the
parent-chain-second-check
branch
from
51b3fb2
to
92a9203
Compare
dapplion
force-pushed
the
parent-chain-second-check
branch
from
92a9203
to
f971878
Compare
|
@mergify queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at f14f21f |
This was referenced Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Sync lookup bounds the maximum length of parent chains. Current code covered the case where a new parent lookup extended the ancestor of a parent chain beyond the max length. However, there's a second case. Consider these events:
Proposed Changes
Bound lookup parent chain length with tip extension. Extending the sequence of events above:
ParentUnknownsearch_parent_of_child(parent, block)This PR introduces the max length bound in this final step