Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EIP-7594 boilerplate #5734

Closed
wants to merge 1 commit into from
Closed

Conversation

jimmygchen
Copy link
Member

@jimmygchen jimmygchen commented May 7, 2024

Issue Addressed

Add EIP-7594 boilerplate.

This fork is built on top of Deneb, and its types currently have the exact same structure as Deneb types.

This PR adds the boiler plate only, will do a separate PR for:

  • Activating PeerDAS at EIP-7594 fork.
  • Removing the PEER_DAS_EPOCH soft fork config.

@jimmygchen jimmygchen added ready-for-review The code is ready for review das Data Availability Sampling labels May 7, 2024
@jimmygchen jimmygchen force-pushed the eip7594-fork branch 2 times, most recently from cef8853 to c8cbeae Compare May 7, 2024 11:26
Copy link
Collaborator

@dapplion dapplion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From offline interop chat discussion the fork boilerplate won't be necessary.
There is no data structure change in EIP7594.

Testnets will use either of these two configurations:

  • EIP7594_FORK_VERSION = DENEB_FORK_VERSION, EIP7594_FORK_EPOCH = 0: no need for fork triggers, same fork version as deneb
  • EIP7594_FORK_VERSION = DENEB_FORK_VERSION, EIP7594_FORK_EPOCH > 0: same fork version as deneb, having a PEERDAS_ACTIVATION_EPOCH = EIP7594_FORK_EPOCH will result is correct behaviour

Unless PeerDAS requires data structure changes we can keep a peerdas_activation_epoch config variable internally and set it to the value of config parameter EIP7594_FORK_EPOCH

@jimmygchen
Copy link
Member Author

Nice, thanks!
Closing this for now. We already have PEER_DAS_EPOCH implemented (happy to rename) and should be sufficient for interop.

@jimmygchen jimmygchen closed this May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
das Data Availability Sampling ready-for-review The code is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants