Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename deploy_block in network config #5850

Merged
merged 3 commits into from
May 29, 2024

Conversation

pawanjay176
Copy link
Member

Issue Addressed

eth-clients/holesky#104

Proposed Changes

Rename deploy_block.txt which was a Lighthouse specific config file to the agreed upon standard.

Additional Info

This shouldn't cause any backward incompatibility issues with built in network configs.
This would cause backwards incompatibility issues with older versions of lighthouse trying to load networks with just deploy_block.txt in the testnet-dir which isn't a big deal imo.

@pawanjay176 pawanjay176 added ready-for-review The code is ready for review backwards-incompat Backwards-incompatible API change labels May 27, 2024
Copy link
Member

@jimmygchen jimmygchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jimmygchen
Copy link
Member

@michaelsproul could use another review here before we merge just to be sure. I think this may break some testing tools, but that's probably it?

@michaelsproul
Copy link
Member

I reckon good to go

@jimmygchen
Copy link
Member

Looks like lcli need a rebuild on the runners:

Unable to open testnet dir at "/home/runner/.lighthouse/local-testnet/testnet": Unable to open deposit_contract_block.txt: Os { code: 2, kind: NotFound, message: "No such file or directory" }

I'm thinking it might be worth to just build lcli all the time now it takes less than 3 minutes on the self hosted runners?

@jimmygchen
Copy link
Member

PR to build lcli: #5860
This PR can be queued after that one.

@realbigsean
Copy link
Member

@mergify queue

Copy link

mergify bot commented May 29, 2024

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 6daeec3

@mergify mergify bot merged commit 6daeec3 into sigp:unstable May 29, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backwards-incompat Backwards-incompatible API change ready-for-merge This PR is ready to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants