Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add block_gossip Beacon API events #5864

Merged
merged 39 commits into from
Jul 16, 2024

Conversation

chong-he
Copy link
Member

Add block_gossip topic to the beacon API eth1/v1/events

Thank you @michaelsproul for the guidance and help

@chong-he chong-he added work-in-progress PR is a work-in-progress HTTP-API labels May 30, 2024
@chong-he chong-he added ready-for-review The code is ready for review and removed work-in-progress PR is a work-in-progress labels Jun 6, 2024
@chong-he chong-he added the v5.2.1 Patch release for v5.2.0 label Jun 24, 2024
@michaelsproul
Copy link
Member

I'm going to drop this from 5.2.1 as it's not an essential part of the hotfix

@michaelsproul michaelsproul added v5.3.0 Q3 2024 release with database changes! and removed v5.2.1 Patch release for v5.2.0 labels Jun 25, 2024
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests look good, and I tested manually to ensure we were using quotes on the slot (we are). Good to go for 5.3

@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Jul 16, 2024
@michaelsproul
Copy link
Member

@mergify queue

Copy link

mergify bot commented Jul 16, 2024

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 79680c8

mergify bot added a commit that referenced this pull request Jul 16, 2024
@mergify mergify bot merged commit 79680c8 into sigp:unstable Jul 16, 2024
28 checks passed
@chong-he chong-he deleted the BeaconAPI-events-block-gossip branch July 16, 2024 05:38
ThreeHrSleep pushed a commit to ThreeHrSleep/lighthouse that referenced this pull request Aug 1, 2024
* Add bls event

* Update events and types

* Add bls in event

* Event bls

* tests..rs

* change order

* another tests.rs

* Signed BLS

* Revert "another tests.rs"

This reverts commit 7f54e9c.

* Revert "Signed BLS"

This reverts commit 1146bc7.

* withdrawal_keyparis

* Fix genesis

* block gossip

* Add definition for BlockGossip

* Fix block gossip

* Tests.rs

* Update block and events

* Add bls event

* Event bls

* tests..rs

* change order

* another tests.rs

* Signed BLS

* Revert "another tests.rs"

This reverts commit 7f54e9c.

* Revert "Signed BLS"

This reverts commit 1146bc7.

* block gossip

* Add definition for BlockGossip

* Fix block gossip

* Tests.rs

* Update block and events

* Merge branch 'BeaconAPI-events-block-gossip' of https://github.com/chong-he/lighthouse into BeaconAPI-events-block-gossip

* Remove tests

* Tests.rs

* Tests.rs

* Tests.rs

* Tests similar to block event

* Update common/eth2/src/types.rs

Co-authored-by: Michael Sproul <micsproul@gmail.com>

* Merge remote-tracking branch 'origin/unstable' into BeaconAPI-events-block-gossip

* Fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
HTTP-API ready-for-merge This PR is ready to merge. v5.3.0 Q3 2024 release with database changes!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants