Iterate expired components from the da_checker #5895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thoughts on including this in 5.2 if we are about to re-test over the weekend? |
beacon_node/beacon_chain/src/data_availability_checker/overflow_lru_cache.rs
Outdated
Show resolved
Hide resolved
|
On 2nd thoughts I don't think this is worth including in 5.2. Let's get 5.2 done and then we can consider a follow-up release |
|
Do we still need this now that the overflow cache is gone? |
Yes, the in-memory map has a leak that is independent to the disk portion that just got dropped. |
dapplion
force-pushed
the
dachecker-prune
branch
from
d3c19a8
to
cfbfc2f
Compare
realbigsean
added
ready-for-merge
|
@mergify queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 24169b2 |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Closes #5892
Proposed Changes
On the pruning routine, iterate expired entries both when threshold is reached and when it's not