Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update local testnet documentation #5896

Merged
merged 12 commits into from
Jun 18, 2024
Merged

Update local testnet documentation #5896

merged 12 commits into from
Jun 18, 2024

Conversation

chong-he
Copy link
Member

@chong-he chong-he commented Jun 6, 2024

Issue Addressed

Completes the last task on #5865

Thanks @jimmygchen for the comments

@chong-he chong-he added the ready-for-review The code is ready for review label Jun 6, 2024
@chong-he chong-he requested a review from jimmygchen June 6, 2024 00:39
jimmygchen
jimmygchen approved these changes Jun 6, 2024
View reviewed changes
Copy link
Member

@jimmygchen jimmygchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a minor fix.
Looks great to me! Thanks CK ☺️

@jimmygchen jimmygchen added ready-for-merge This PR is ready to merge. test improvement Improve tests docs Documentation and removed ready-for-review The code is ready for review test improvement Improve tests labels Jun 6, 2024
pawanjay176
pawanjay176 reviewed Jun 6, 2024
View reviewed changes
scripts/local_testnet/README.md Outdated Show resolved Hide resolved
scripts/local_testnet/README.md Show resolved Hide resolved
@jimmygchen jimmygchen added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-merge This PR is ready to merge. labels Jun 13, 2024
chong-he and others added 2 commits June 14, 2024 21:00
@chong-he @pawanjay176
Update scripts/local_testnet/README.md
2431571 
Co-authored-by: Pawan Dhananjay <pawandhananjay@gmail.com>
@chong-he
Add kurtosis web
e128165
@chong-he chong-he added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Jun 14, 2024
chong-he and others added 2 commits June 18, 2024 08:12
@chong-he
Log of a service
a623bb6
@chong-he @jimmygchen
Update scripts/local_testnet/README.md
b3902f3 
Co-authored-by: Jimmy Chen <jchen.tc@gmail.com>
@chong-he @jimmygchen
Update scripts/local_testnet/README.md
7a71cda 
Co-authored-by: Jimmy Chen <jchen.tc@gmail.com>
@jimmygchen jimmygchen added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Jun 18, 2024
jimmygchen
jimmygchen approved these changes Jun 18, 2024
View reviewed changes
Copy link
Member

@jimmygchen jimmygchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks CK!

@jimmygchen
Copy link
Member

@mergify queue

@mergify Mergify
Copy link

mergify bot commented Jun 18, 2024 •
edited
Loading

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at ab7db7c

mergify bot added a commit that referenced this pull request Jun 18, 2024
@mergify
Merge of #5896
fd292aa
@mergify mergify bot mentioned this pull request Jun 18, 2024
Closed
5 tasks
@mergify mergify bot merged commit ab7db7c into sigp:unstable Jun 18, 2024
28 checks passed
@chong-he chong-he deleted the local-testnet-doc branch July 16, 2024 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pawanjay176 pawanjay176 pawanjay176 left review comments

@jimmygchen jimmygchen jimmygchen approved these changes

Assignees
No one assigned
Labels
docs Documentation ready-for-merge This PR is ready to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chong-he @jimmygchen @pawanjay176