Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix skip-ci on stable #5909

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Fix skip-ci on stable #5909

merged 1 commit into from
Jun 13, 2024

Conversation

jimmygchen
Copy link
Member

@jimmygchen jimmygchen commented Jun 11, 2024

Issue Addressed

Fix skip-ci job triggered by pushing to branches. Also replaced the deprecated ::set-output command.

I've tested this on a push to my fork, and it evaluates null without failing:
https://github.com/jimmygchen/lighthouse/actions/runs/9457252549/job/26050717847

@jimmygchen jimmygchen added skip-ci Don't run the `test-suite` infra-ci ready-for-review The code is ready for review labels Jun 11, 2024
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As much as I hate "null" as a string, this looks like it would work

LGTM

@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Jun 11, 2024
@michaelsproul
Copy link
Member

@Mergifyio queue

Copy link

mergify bot commented Jun 11, 2024

queue

🛑 The pull request has been removed from the queue default

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

mergify bot added a commit that referenced this pull request Jun 11, 2024
@realbigsean realbigsean removed the skip-ci Don't run the `test-suite` label Jun 11, 2024
@michaelsproul
Copy link
Member

@Mergifyio requeue

Copy link

mergify bot commented Jun 13, 2024

requeue

✅ This pull request will be re-embarked automatically

The followup queue command will be automatically executed to re-embark the pull request

Copy link

mergify bot commented Jun 13, 2024

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 1bcd1f1

mergify bot added a commit that referenced this pull request Jun 13, 2024
@mergify mergify bot merged commit 1bcd1f1 into sigp:unstable Jun 13, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra-ci ready-for-merge This PR is ready to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants