Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various fixes to custody range sync #6004

Merged
merged 17 commits into from
Jul 16, 2024
Merged

Various fixes to custody range sync #6004

merged 17 commits into from
Jul 16, 2024

Commits on Jun 27, 2024

  1. Only start requesting batches when there are good peers across all cu… 

    …stody columns to avoid spaming block requests.
    @jimmygchen
    jimmygchen committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    edc584a View commit details
    Browse the repository at this point in the history

  2. Add custody peer check before mutating BatchInfo to avoid inconsist… 

    …ent state.
    @jimmygchen
    jimmygchen committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    9f82497 View commit details
    Browse the repository at this point in the history

  3. Add check to cover a case where batch is not processed while waiting … 

    …for custody peers to become available.
    @jimmygchen
    jimmygchen committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    05608b0 View commit details
    Browse the repository at this point in the history

  4. Fix lint and logic error

    @jimmygchen
    jimmygchen committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    9f20029 View commit details
    Browse the repository at this point in the history

  5. Fix good_peers_on_subnet always returning false for `DataColumnSubn… 

    …et`.
    @jimmygchen
    jimmygchen committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    4079d2e View commit details
    Browse the repository at this point in the history

  6. Merge branch 'das' into custody-sync-peers

    @jimmygchen
    jimmygchen committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    de05355 View commit details
    Browse the repository at this point in the history

  7. Add test for get_custody_peers_for_column

    @jimmygchen
    jimmygchen committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    876ea3b View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2024

  1. Revert epoch parameter refactor.

    @jimmygchen
    jimmygchen committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    4373a28 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2024

  1. Fall back to default custody requiremnt if peer ENR is not present.

    @jimmygchen
    jimmygchen committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    03a9dce View commit details
    Browse the repository at this point in the history

  2. Add metrics and update code comment.

    @jimmygchen
    jimmygchen committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    cfb3ebc View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2024

  1. Add more debug logs.

    @jimmygchen
    jimmygchen committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    0a27146 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'das' into custody-sync-peers

    @jimmygchen
    jimmygchen committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    9cfbfa6 View commit details
    Browse the repository at this point in the history

  3. Use subscribed peers on subnet before MetaDataV3 is implemented. Remo… 

    …ve peer_id matching when injecting error because multiple peers are used for range requests. Use randomized custodial peer to avoid repeatedly sending requests to failing peers. Batch by range request where possible.
    @jimmygchen
    jimmygchen committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    bf70fb4 View commit details
    Browse the repository at this point in the history

  4. Remove unused code and update docs.

    @jimmygchen
    jimmygchen committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    c10fe36 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2024

  1. Merge branch 'das' into custody-sync-peers 

    # Conflicts:
#	beacon_node/network/src/sync/network_context.rs
#	beacon_node/network/src/sync/range_sync/batch.rs
    @jimmygchen
    jimmygchen committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    9cfc670 View commit details
    Browse the repository at this point in the history

  2. Add comment

    @jimmygchen
    jimmygchen committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    6ff408f View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2024

  1. Merge branch 'das' into custody-sync-peers 

    # Conflicts:
#	beacon_node/network/src/sync/sampling.rs
    @jimmygchen
    jimmygchen committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    e04f98d View commit details
    Browse the repository at this point in the history