-
Notifications
You must be signed in to change notification settings - Fork 747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Downgrade duplication log of attestation to Debug #6007
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chong-he
added
ready-for-review
The code is ready for review
and removed
work-in-progress
PR is a work-in-progress
labels
Jul 1, 2024
michaelsproul
approved these changes
Jul 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvement, thanks CK!
@mergify queue |
michaelsproul
added
ready-for-merge
This PR is ready to merge.
v5.3.0
Q3 2024 release with database changes!
and removed
ready-for-review
The code is ready for review
labels
Jul 4, 2024
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at d9ad1f5 |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ready-for-merge
This PR is ready to merge.
UX-and-logs
v5.3.0
Q3 2024 release with database changes!
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Proposed Changes
Only display the first log of
Attestation included in aggregate
andAttestation included in block
asINFO
and downgrade subsequent logs toDEBG
. This will reduce verbosity of the logs whenvalidator-monitor-auto
is turned on.Additional Info
For
Attestation included in aggregate
:Before:
After:
For
Attestation included in block
:Before:
After: