Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete duplicated serde code #6027

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

michaelsproul
Copy link
Member

Proposed Changes

Found some serde code for IndexedAttestation that is just copy-pasta of stuff we already have in ethereum_serde_utils. I think it actually predates that module though, and the duplication just never got cleaned up (until now).

The new code also supports omitting quotes during deserialisation, so there is no breaking change here: https://docs.rs/ssz_types/latest/ssz_types/serde_utils/quoted_u64_var_list/index.html

@michaelsproul michaelsproul added ready-for-review The code is ready for review code-quality labels Jul 1, 2024
Copy link
Member

@realbigsean realbigsean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@realbigsean
Copy link
Member

@mergify queue

Copy link

mergify bot commented Jul 1, 2024

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 3f2af5c

mergify bot added a commit that referenced this pull request Jul 1, 2024
@mergify mergify bot merged commit 3f2af5c into sigp:unstable Jul 1, 2024
28 checks passed
@michaelsproul michaelsproul deleted the serde-utils-cleanup branch July 1, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-quality ready-for-review The code is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants