Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show blst hardware support in lighthouse --version #6039

Merged
merged 4 commits into from
Jul 5, 2024
Merged

Show blst hardware support in lighthouse --version #6039

merged 4 commits into from
Jul 5, 2024

Conversation

scafe3
Copy link
Contributor

@scafe3 scafe3 commented Jul 3, 2024

Show blst hardware support in lighthouse --version:

$ ./target/debug/lighthouse --version
Lighthouse v5.2.1
BLS library: blst-portable
BLS hardware acceleration: false
SHA256 hardware acceleration: true
Allocator: system
Profile: debug
Specs: mainnet (true), minimal (false), gnosis (false)

Will close #5918

@CLAassistant
Copy link

CLAassistant commented Jul 3, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

michaelsproul
michaelsproul requested changes Jul 3, 2024
View reviewed changes
lighthouse/src/main.rs Outdated Show resolved Hide resolved
@michaelsproul michaelsproul added waiting-on-author The reviewer has suggested changes and awaits thier implementation. UX-and-logs labels Jul 3, 2024
@scafe3 scafe3 requested a review from michaelsproul July 3, 2024 15:22
michaelsproul
michaelsproul requested changes Jul 4, 2024
View reviewed changes
lighthouse/src/main.rs Outdated Show resolved Hide resolved
lighthouse/src/main.rs Show resolved Hide resolved
lighthouse/src/main.rs Outdated Show resolved Hide resolved
@scafe3 scafe3 requested a review from michaelsproul July 4, 2024 02:31
michaelsproul
michaelsproul approved these changes Jul 5, 2024
View reviewed changes
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

Tested on my M1 Pro Mac and it shows true!

@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Jul 5, 2024
@michaelsproul
Copy link
Member

@mergify queue

@mergify Mergify
Copy link

mergify bot commented Jul 5, 2024 •
edited
Loading

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 5b2edfa

mergify bot added a commit that referenced this pull request Jul 5, 2024
@mergify
Merge of #6039
fd28bc4
@mergify mergify bot mentioned this pull request Jul 5, 2024
Closed
5 tasks
@mergify mergify bot merged commit 5b2edfa into sigp:unstable Jul 5, 2024
27 of 28 checks passed
@scafe3
Copy link
Contributor Author

scafe3 commented Jul 5, 2024

@michaelsproul Thanks for your guidance!

@chong-he chong-he mentioned this pull request Jul 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelsproul michaelsproul michaelsproul approved these changes

Assignees
No one assigned
Labels
ready-for-merge This PR is ready to merge. UX-and-logs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scafe3 @CLAassistant @michaelsproul