Track store metrics by DB column #6041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dapplion
commented
Jul 3, 2024
| leveldb_batch.put(BytesKey::from_vec(key), &value); | ||
| } | ||
|
|
||
| KeyValueStoreOp::DeleteKey(key) => { | ||
| let col = get_col_from_key(&key).unwrap_or("unknown".to_owned()); |
There was a problem hiding this comment.
get_col_from_key should never error as we define the DBColumn enum variants. The use of col is purely informational on metrics, so unwrapping to unknown to have something
michaelsproul
added
ready-for-merge
|
@mergify queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at b0b142c |
This was referenced Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
When adding metrics for
Noted that the DB metrics are already there but we don't track them by column. I would like to be able to tell:
Proposed Changes
IntCountertoIntCounterVecand label by column enum 3 letter string.do_atomicallycalls, optimistically assuming success