Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete old database schemas #6051

Merged
merged 3 commits into from
Jul 9, 2024
Merged

Delete old database schemas #6051

merged 3 commits into from
Jul 9, 2024

Conversation

michaelsproul
Copy link
Member

Proposed Changes

With Deneb activated on every supported network, it is no longer possible to downgrade to a DB schema prior to V19. This PR deletes all migrations and structs related to versions prior to V19. Hopefully this reduces maintenance burden a little, and maybe reduces compile times slightly!

@michaelsproul
Copy link
Member Author

Seeking review from the chief deleter of cruft @macladson 🙏

@michaelsproul michaelsproul added ready-for-review The code is ready for review code-quality v5.3.0 Q3 2024 release with database changes! labels Jul 5, 2024
Copy link
Member

@chong-he chong-he left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to make it consistent with the v together with version number as other rows

book/src/database-migrations.md Outdated Show resolved Hide resolved
book/src/database-migrations.md Outdated Show resolved Hide resolved
Copy link
Member

@macladson macladson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Jul 8, 2024
@michaelsproul
Copy link
Member Author

@mergify queue

Copy link

mergify bot commented Jul 8, 2024

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 9942c18

mergify bot added a commit that referenced this pull request Jul 8, 2024
@mergify mergify bot merged commit 9942c18 into unstable Jul 9, 2024
29 checks passed
@mergify mergify bot deleted the delete-old-schemas branch July 9, 2024 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-quality ready-for-merge This PR is ready to merge. v5.3.0 Q3 2024 release with database changes!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants