Show correct total validator count during validator recovery

[dknopik]

Issue Addressed

A small one I found just now: The progress indicator displayed during lighthouse account validator recover would show something like 0/4294967276 Index: 40 when count < first_index.

Proposed Changes

Simply display the count there instead of subtracting the first index.

Additional Info

None.

[chong-he]

Thanks for the contribution, nice catch!

Just a nitpick, thought it would be better to have the count as count - 1, since the count displayed starts from 0. So, when we do:

lighthouse account validator recover --first-index 4 --count 2, it will show:

0/1
1/1 

instead of:

0/2 
1/2

Edit: other than that, tested and confirmed the UX shown as intended and it's good

[dknopik]

Hey @chong-he, good point. But then actually, I would argue for

1/2 
2/2

which might be more intuitive to users, as people usually index starting at 1 in non-code contexts. But that is a matter of taste I guess.

[chong-he]

Good point, that would be:

 index - first_index + 1,
 count,

I have commented above as well.

I think this is good to go

[jimmygchen]

@mergify queue

[mergify]

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at b4a7560