Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert --image-download always flag to avoid CI getting rate limited #6163

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

jimmygchen
Copy link
Member

Issue Addressed

Partially #6161.

This PR reverts --image-download=always flag to avoid CI getting rate limited by Docker Hub. It looks like the Kurtosis tests are now pulling all images every job, whereas it wasn't doing this before the flag was added.

@jimmygchen jimmygchen added ready-for-review The code is ready for review infra-ci labels Jul 24, 2024
Copy link
Member

@antondlr antondlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jimmygchen
Copy link
Member Author

@mergify queue

@jimmygchen jimmygchen added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Jul 24, 2024
Copy link

mergify bot commented Jul 24, 2024

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at b36f77e

mergify bot added a commit that referenced this pull request Jul 24, 2024
mergify bot added a commit that referenced this pull request Jul 24, 2024
@mergify mergify bot merged commit b36f77e into sigp:unstable Jul 24, 2024
28 checks passed
@jimmygchen jimmygchen deleted the revert-image-download-always branch July 26, 2024 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra-ci ready-for-merge This PR is ready to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants