chore: update and enable PeerDAS tests to latest spec test release (1.5.0-alpha-5)
#6312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevaundray
force-pushed
the
kw/enable-das-kzg-tests
branch
from
c2b8041 to
7af67c1
Compare
chong-he
added
test improvement
jimmygchen
reviewed
Aug 28, 2024
jimmygchen
force-pushed
the
kw/enable-das-kzg-tests
branch
from
370c57b to
4295f7a
Compare
jimmygchen
force-pushed
the
kw/enable-das-kzg-tests
branch
from
4295f7a to
5d7f744
Compare
jimmygchen
changed the title
1.5.0-alpha-5)
dapplion
approved these changes
Aug 28, 2024
|
Seems CI is unstable with the test |
|
Raised issue for the flaky test |
jimmygchen
added
ready-for-merge
|
@mergify queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 653126f |
This was referenced Aug 28, 2024
AgeManning
pushed a commit
to AgeManning/lighthouse
that referenced
this pull request
Sep 3, 2024
…1.5.0-alpha-5`) (sigp#6312) * enable DAS tests * update spec testing code * Update PeerDAS kzg tests input structures to latest spec. * Update `ef_tests` ignore files.
chong-he
pushed a commit
to chong-he/lighthouse
that referenced
this pull request
Nov 26, 2024
…1.5.0-alpha-5`) (sigp#6312) * enable DAS tests * update spec testing code * Update PeerDAS kzg tests input structures to latest spec. * Update `ef_tests` ignore files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
This enables the peerDAS test which were previously commented out. The main issue for this seems to be rayon's local threadpool not working well with rayon's global threadpool. The local threadpool has been disabled along with rayon following 6309
Proposed Changes
This PR is built ontop of 6309 and 6312, so the diff is more than it should be.
The changes introduced in this PR:
Modify the spec test for
verify_cell_kzg_proof_batchso that its forward compatible with the new API. Once the consensus-specs are updated, we can remove the TODOs.Removed the commenting out of the kzg tests.
Additional Info
Please provide any additional information. For example, future considerations
or information useful for reviewers.