Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin ethereum-package version to 4.2.0 #6315

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

jimmygchen
Copy link
Member

@jimmygchen jimmygchen commented Aug 28, 2024

Issue Addressed

  • Pin ethereum-package version to 4.2.0, instead of using latest (pinning this because dora isn't working in the latest version and is good practice anyways)
  • Update das config file with 1 additional node
  • Remove unused das network configs.

@jimmygchen jimmygchen added test improvement Improve tests ready-for-review The code is ready for review das Data Availability Sampling labels Aug 28, 2024
@jimmygchen jimmygchen requested a review from pawanjay176 August 28, 2024 06:50
@pawanjay176 pawanjay176 added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Aug 28, 2024
@jimmygchen
Copy link
Member Author

@mergify merge

Copy link

mergify bot commented Aug 29, 2024

merge

❌ Sorry but I didn't understand the command. Please consult the commands documentation 📚.

@jimmygchen
Copy link
Member Author

@mergify queue

@jimmygchen
Copy link
Member Author

Sorry @mergify, too desperate.

Copy link

mergify bot commented Aug 29, 2024

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 218ae5c

mergify bot added a commit that referenced this pull request Aug 29, 2024
@mergify mergify bot merged commit 218ae5c into sigp:unstable Aug 29, 2024
28 checks passed
AgeManning pushed a commit to AgeManning/lighthouse that referenced this pull request Sep 3, 2024
* Pin `ethereum-package` version, update das kurtosis config file and remove outdated config files.
chong-he pushed a commit to chong-he/lighthouse that referenced this pull request Nov 26, 2024
* Pin `ethereum-package` version, update das kurtosis config file and remove outdated config files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
das Data Availability Sampling ready-for-merge This PR is ready to merge. test improvement Improve tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants