Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reason of NoRequestNeeded to lookup sync #6317

Merged
merged 2 commits into from
Aug 30, 2024

Conversation

dapplion
Copy link
Collaborator

Issue Addressed

Porting improvement from

Proposed Changes

Now there are more reasons why a lookup request will be NoRequestNeeded. To debug stuck sync lookup it's important to know why sync would consider the request unnecessary.

@dapplion dapplion added ready-for-review The code is ready for review das Data Availability Sampling labels Aug 28, 2024
Copy link
Member

@jimmygchen jimmygchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I think this will help with debugging 👍

@jimmygchen jimmygchen added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Aug 30, 2024
@jimmygchen
Copy link
Member

@mergify queue

Copy link

mergify bot commented Aug 30, 2024

queue

🛑 The pull request has been removed from the queue default

The pull request conflicts with at least one pull request ahead in queue.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

# Conflicts:
#	beacon_node/network/src/sync/network_context.rs
@jimmygchen
Copy link
Member

@mergify queue

Copy link

mergify bot commented Aug 30, 2024

queue

🛑 The pull request has been removed from the queue default

The merge conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

mergify bot added a commit that referenced this pull request Aug 30, 2024
@jimmygchen
Copy link
Member

@mergify requeue

Copy link

mergify bot commented Aug 30, 2024

requeue

✅ This pull request will be re-embarked automatically

The followup queue command will be automatically executed to re-embark the pull request

Copy link

mergify bot commented Aug 30, 2024

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 60157ad

mergify bot added a commit that referenced this pull request Aug 30, 2024
@mergify mergify bot merged commit 60157ad into sigp:unstable Aug 30, 2024
28 checks passed
@dapplion dapplion deleted the peerdas-reason branch September 2, 2024 12:57
AgeManning pushed a commit to AgeManning/lighthouse that referenced this pull request Sep 3, 2024
* Add reason of NoRequestNeeded to lookup sync

* Merge branch 'unstable' into peerdas-reason

# Conflicts:
#	beacon_node/network/src/sync/network_context.rs
chong-he pushed a commit to chong-he/lighthouse that referenced this pull request Nov 26, 2024
* Add reason of NoRequestNeeded to lookup sync

* Merge branch 'unstable' into peerdas-reason

# Conflicts:
#	beacon_node/network/src/sync/network_context.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
das Data Availability Sampling ready-for-merge This PR is ready to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants