-
Notifications
You must be signed in to change notification settings - Fork 784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reason of NoRequestNeeded to lookup sync #6317
Conversation
d4581c8
to
c0fa672
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, I think this will help with debugging 👍
@mergify queue |
🛑 The pull request has been removed from the queue
|
# Conflicts: # beacon_node/network/src/sync/network_context.rs
@mergify queue |
🛑 The pull request has been removed from the queue
|
@mergify requeue |
✅ This pull request will be re-embarked automaticallyThe followup |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 60157ad |
* Add reason of NoRequestNeeded to lookup sync * Merge branch 'unstable' into peerdas-reason # Conflicts: # beacon_node/network/src/sync/network_context.rs
* Add reason of NoRequestNeeded to lookup sync * Merge branch 'unstable' into peerdas-reason # Conflicts: # beacon_node/network/src/sync/network_context.rs
Issue Addressed
Porting improvement from
Proposed Changes
Now there are more reasons why a lookup request will be
NoRequestNeeded
. To debug stuck sync lookup it's important to know why sync would consider the request unnecessary.