Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix electra light client types #6361

Merged
merged 114 commits into from
Oct 25, 2024
Merged

Fix electra light client types #6361

merged 114 commits into from
Oct 25, 2024

Conversation

eserilev
Copy link
Collaborator

@eserilev eserilev commented Sep 5, 2024 •
edited
Loading

Issue Addressed

Resolves #6002

Resolves #4022

Proposed Changes

Update light client types to be compatible with electra

Related spec PR:

ethereum/consensus-specs#3811

Blocked by #5915

@eserilev
persist light client updates
914bb1e
@eserilev
update beacon chain to serve light client updates
c308768
@eserilev
resolve todos
e332b00
@eserilev
cache best update
3a93933
@eserilev
extend cache parts
b9bdd88
@eserilev
is better light client update
9671423
@eserilev
resolve merge conflict
5861417
@eserilev
initial api changes
6e0fa26
@eserilev
add lc update db column
c8af8fb
@eserilev
fmt
45a5d8d
@eserilev
added tests
2545655
@eserilev
add sim
3029f2c
@eserilev
Merge branch 'unstable' of https://github.com/sigp/lighthouse into pe…
fad083a 
…rsist-light-client-updates
@eserilev
fix some weird issues with the simulator
49a7e61
@eserilev
tests
00d4fd0
@eserilev
Merge branch 'unstable' of https://github.com/sigp/lighthouse into pe…
4b8683c 
…rsist-light-client-updates
@eserilev
test changes
6f12133
@eserilev
merge conflict
9464518
@eserilev
testing
22e9201
@eserilev
started work on ef tests and some code clean up
1946100
@eserilev
update tests
2b1e47d
@eserilev
linting
211601c
@eserilev
noop pre altair, were still failing on electra though
891d677
@eserilev
allow for zeroed light client header
d729fea
@eserilev
Merge branch 'unstable' of https://github.com/sigp/lighthouse into pe…
58f178a 
…rsist-light-client-updates
@eserilev
merge unstable
fe2b43d
@eserilev
remove unwraps
1774e63
@eserilev
remove unwraps
af9b20d
@eserilev
fetch bootstrap without always querying for state
d82226b
@eserilev
storing bootstrap parts in db
ce765f3
dapplion
dapplion approved these changes Sep 18, 2024
View reviewed changes
Copy link
Collaborator

@dapplion dapplion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Until we have generalized proof generation this version looks like the most sound to me

michaelsproul
michaelsproul previously requested changes Sep 23, 2024
View reviewed changes
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I just pushed a small change to reduce new fork burden: 7d67d0d

One small naming nit, and then we can merge

consensus/types/src/light_client_update.rs Outdated Show resolved Hide resolved
@michaelsproul michaelsproul added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Sep 23, 2024
@eserilev eserilev added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Sep 23, 2024
dapplion
dapplion approved these changes Sep 25, 2024
View reviewed changes
Copy link
Collaborator

@dapplion dapplion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jimmygchen jimmygchen added ready-for-merge This PR is ready to merge. ready-for-review The code is ready for review and removed ready-for-review The code is ready for review ready-for-merge This PR is ready to merge. labels Sep 30, 2024
@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Oct 25, 2024
@michaelsproul
Copy link
Member

@mergify queue

@mergify Mergify
Copy link

mergify bot commented Oct 25, 2024 •
edited
Loading

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 9d069a9

mergify bot added a commit that referenced this pull request Oct 25, 2024
@mergify
Merge of #6361
9c08a39
@mergify mergify bot mentioned this pull request Oct 25, 2024
Closed
5 tasks
@mergify mergify bot merged commit 9d069a9 into sigp:unstable Oct 25, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dapplion dapplion dapplion approved these changes

@michaelsproul michaelsproul michaelsproul approved these changes

Assignees
No one assigned
Labels
electra Required for the Electra/Prague fork light-client ready-for-merge This PR is ready to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eserilev @michaelsproul @dapplion @jimmygchen