-
Notifications
You must be signed in to change notification settings - Fork 746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Book: fix broken link in merge-migration.md #6370
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for reporting this, however I don't think the link provided is the right link for configuring Besu, I don't see the instructions there.
Maybe we can put the link to configure Besu: https://besu.hyperledger.org/public-networks/get-started/connect/mainnet Having said that, I wonder should we add a section in the Lighthouse book titled |
Thanks for the tips fixed now!
or we could directly delete them? |
That could be fine, but keeping them may serve as future references just in case (e.g., some users may want to have a read at the R Pi 4 docs, or what happened back then during The Merge). Keen to hear from others about this |
@chong-he Hi, I'm wondering if there is anything more I need to fix in this PR? |
Not at the moment. Specifically, for small PR changes (e.g., 1-line), we have the following note to maintain the project quality: So, we will see if the devs would think having more changes (e.g., add a deprecated section or other updates) is required. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new link LGTM.
I think we can probably address @chong-he's suggestions separately.
EDIT: sorry just discussed with the team and decided that we will archive this section
Issue raised: #6447 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
API key 1ljbmqcbqlxlscfngtoa6dxejqagazxjomusnb1xvh4vzoomv35erilbhmqdjme0
@@ -66,7 +66,7 @@ the relevant page for your execution engine for the required flags: | |||
|
|||
- [Geth: Connecting to Consensus Clients](https://geth.ethereum.org/docs/getting-started/consensus-clients) | |||
- [Nethermind: Running Nethermind Post Merge](https://docs.nethermind.io/nethermind/first-steps-with-nethermind/running-nethermind-post-merge) | |||
- [Besu: Prepare For The Merge](https://besu.hyperledger.org/en/stable/HowTo/Upgrade/Prepare-for-The-Merge/) | |||
- [Besu: Prepare For The Merge](https://besu.hyperledger.org/public-networks/get-started/connect/mainnet) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there, the original link is expired, I found this one may be the correct one.