Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Book: fix broken link in merge-migration.md #6370

Closed
wants to merge 2 commits into from

Conversation

silvekkk
Copy link

@silvekkk silvekkk commented Sep 7, 2024

Hi there, the original link is expired, I found this one may be the correct one.

@CLAassistant
Copy link

CLAassistant commented Sep 7, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@jimmygchen jimmygchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reporting this, however I don't think the link provided is the right link for configuring Besu, I don't see the instructions there.

@jimmygchen jimmygchen added waiting-on-author The reviewer has suggested changes and awaits thier implementation. docs Documentation labels Sep 9, 2024
@chong-he
Copy link
Member

chong-he commented Sep 9, 2024

Maybe we can put the link to configure Besu: https://besu.hyperledger.org/public-networks/get-started/connect/mainnet

Having said that, I wonder should we add a section in the Lighthouse book titled Archived and keep all deprecated and archived pages under it? Examples include:

@silvekkk
Copy link
Author

silvekkk commented Sep 9, 2024

Maybe we can put the link to configure Besu: https://besu.hyperledger.org/public-networks/get-started/connect/mainnet

Thanks for the tips fixed now!

Having said that, I wonder should we add a section in the Lighthouse book titled Archived and keep all deprecated and archived pages under it? Examples include:

or we could directly delete them?

@chong-he chong-he added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Sep 10, 2024
@chong-he
Copy link
Member

Maybe we can put the link to configure Besu: https://besu.hyperledger.org/public-networks/get-started/connect/mainnet

Thanks for the tips fixed now!

Having said that, I wonder should we add a section in the Lighthouse book titled Archived and keep all deprecated and archived pages under it? Examples include:

or we could directly delete them?

That could be fine, but keeping them may serve as future references just in case (e.g., some users may want to have a read at the R Pi 4 docs, or what happened back then during The Merge).

Keen to hear from others about this

@silvekkk
Copy link
Author

@chong-he Hi, I'm wondering if there is anything more I need to fix in this PR?

@chong-he
Copy link
Member

@chong-he Hi, I'm wondering if there is anything more I need to fix in this PR?

Not at the moment.

Specifically, for small PR changes (e.g., 1-line), we have the following note to maintain the project quality:
https://github.com/sigp/lighthouse/blob/stable/CONTRIBUTING.md#i-dont-think-i-have-anything-to-add

So, we will see if the devs would think having more changes (e.g., add a deprecated section or other updates) is required.

Copy link
Member

@jimmygchen jimmygchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new link LGTM.
I think we can probably address @chong-he's suggestions separately.

EDIT: sorry just discussed with the team and decided that we will archive this section

@jimmygchen jimmygchen added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review ready-for-merge This PR is ready to merge. labels Sep 30, 2024
@jimmygchen jimmygchen closed this Sep 30, 2024
@jimmygchen
Copy link
Member

Issue raised: #6447

Copy link

@LeesaZiegler LeesaZiegler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API key 1ljbmqcbqlxlscfngtoa6dxejqagazxjomusnb1xvh4vzoomv35erilbhmqdjme0

@@ -66,7 +66,7 @@ the relevant page for your execution engine for the required flags:

- [Geth: Connecting to Consensus Clients](https://geth.ethereum.org/docs/getting-started/consensus-clients)
- [Nethermind: Running Nethermind Post Merge](https://docs.nethermind.io/nethermind/first-steps-with-nethermind/running-nethermind-post-merge)
- [Besu: Prepare For The Merge](https://besu.hyperledger.org/en/stable/HowTo/Upgrade/Prepare-for-The-Merge/)
- [Besu: Prepare For The Merge](https://besu.hyperledger.org/public-networks/get-started/connect/mainnet)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blockware-bundles.csv

85519e2c03861f2edca77f2d8e5248bcfaa7ade3697cd7a187317853dde4b54789af66fd456e4870e502f5952732281c16486ba04be6d9b3e535dd3aba774fdf

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants