Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate account manager cli client to clap derive #6493

Open
wants to merge 5 commits into
base: unstable
Choose a base branch
from
Open

Migrate account manager cli client to clap derive #6493

wants to merge 5 commits into from
+811 −786

Conversation

eserilev
Copy link
Collaborator

Issue Addressed

Partially #5900

Proposed Changes

Migrate account-manager to clap derive

@eserilev eserilev mentioned this pull request Oct 16, 2024
Open
8 tasks
@eserilev eserilev added the ready-for-review The code is ready for review label Oct 16, 2024
macladson
macladson requested changes Oct 26, 2024
View reviewed changes
Copy link
Member

@macladson macladson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this PR needs some of the same love from #6300 since lighthouse am --help also doesn't work.

@macladson macladson added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macladson macladson macladson requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
code-quality waiting-on-author The reviewer has suggested changes and awaits thier implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eserilev @macladson