You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpc_blob_limits was being computed repeatedly even though its a constant value. Move it to a LazyLock block to avoid repeated computation.
Found this taking ~10% of cpu when I was playing around with flamegraph
Moved rpc_tests to run over MainnetEthSpec. I think it made a difference when minimal blob sizes were small. Don't think it makes much of a difference in terms of test speeds now. Not sure if there's any reason to run them over minimal cc @AgeManning for when you are back
Not sure if there's any reason to run them over minimal
We need it for the simulator tests. Running sim tests over MainnetEthSpec will take 8x longer. Can revisit this if we manage to replace sim tests with assertoor tests. Reverted back to minimal in rpc_tests
* Compute blob rpc limits in static block
* Fix min size
* Use MainnetEthSpec in rpc tests
* Revert MainnetEthSpec; add another constant for blob size minimal
low-hanging-fruitEasy to resolve, get it before someone else does!optimizationSomething to make Lighthouse run more efficiently.ready-for-mergeThis PR is ready to merge.v6.0.0New major release for hierarchical state diffs
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pawanjay176
added
low-hanging-fruit
michaelsproul
added
waiting-on-author
Issue Addressed
N/A
Proposed Changes
rpc_blob_limits was being computed repeatedly even though its a constant value. Move it to a LazyLock block to avoid repeated computation.
Found this taking ~10% of cpu when I was playing around with flamegraph