feat(gossipsub): remove control pool #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
which will help for the goal of prioritizing GRAFT and PRUNE messages over IWANT/IHAVE.
when subscribing a topic, instead of doing it in the next heartbeat via control pool.
instead of doing it in the next heartbeat via control pool.
tests are changed due to how count_control_messages work. Previously when counting messages they were consumed from the source: control_pool and the NetworkBehaviour events list, with the new channels, to read a message one has to consume it, that's why test numbers were changed.
jxs
force-pushed
the
remove-control-pool-sigp
branch
from
c8f248b
to
8dd0639
Compare
AgeManning
approved these changes
Dec 6, 2023
This was referenced Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Notes & open questions
Change checklist