Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gossipsub): use connected_peers instead of handler_send_queues #562

Closed
wants to merge 1 commit into from

Conversation

jxs
Copy link
Member

@jxs jxs commented Dec 18, 2023

to avoid extra redundancy.

allow peer retrieval to be fallible when forwarding and publishing messages as peer might still exist in the mesh and explicit peers but is no longer connected.

superseeds #561

Description

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@AgeManning
Copy link
Member

I merged these into #561 with some extra changes like (allowing forward to panic on explicit peers).

@AgeManning AgeManning closed this Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants