Various improvements #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… mesh peers and all peers functions
AgeManning
reviewed
Sep 25, 2020
| @@ -375,7 +375,9 @@ impl Decoder for GossipsubCodec { | |||
| // ensure the sequence number is a u64 | |||
| let sequence_number = if verify_sequence_no { | |||
| if let Some(seq_no) = message.seqno { | |||
| if seq_no.len() != 8 { | |||
| if seq_no.len() == 0 { | |||
There was a problem hiding this comment.
We have all decided that this is invalid and we should register it as such
There was a problem hiding this comment.
Hmmm... note that this check is only active for ValidationMode Strict and Permissive, so it is not really relevant to ETH2, I changed that before we switched to Anonymous because in protobuf a missing value is equivalent to its default (which is in case of bytes the zero byte value).
| invalid_messages.push((message, ValidationError::InvalidPeerId)); | ||
| continue; | ||
| if let Some(bytes) = message.from { | ||
| if bytes.len() > 0 { |
There was a problem hiding this comment.
Same here, bytes.len() == 0 is invalid.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various improvements (see single commits for an overview).