Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address reviewers comments #88

Merged
merged 3 commits into from
Nov 8, 2020
Merged

Conversation

AgeManning
Copy link
Member

Address reviewers comments

Copy link

@blacktemplar blacktemplar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (just one small suggestion)

@@ -28,15 +28,18 @@ use std::collections::{
use std::time::Duration;
use wasm_timer::Instant;

#[derive(Clone)]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Derive Copy to avoid clone calls?

@AgeManning AgeManning merged commit d306455 into gossipsub-v1.1 Nov 8, 2020
@AgeManning AgeManning deleted the reviewers-comments branch June 15, 2021 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants