-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new project root-signing-staging #351
Conversation
Fixes sigstore#345 (although further tweaks may be required: we'll see how the bot permissions match what tuf-on-ci expects, and what is needed to configure Pages publishing from GH actions). Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
🍹
|
allowAutoMerge: false | ||
allowMergeCommit: true | ||
allowRebaseMerge: false | ||
allowSquashMerge: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to allow squash merges? I typically disable merge commits to keep the history clean, allow squash, and allow auto merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not 100% sure but I don't think I do...commits in signing event PRs are meaningful as they come from multiple sources(different signers, repository workflow, etc). Squashing them would look confusing IMO
allowSquashMerge: false | ||
archived: false | ||
autoInit: false | ||
deleteBranchOnMerge: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does automation need a static branch, or does it create new branches frequently? Might want this on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not that frequently, but a branch per signing event. I would maybe rather start with not deleting branches for easier forensics
Gentle ping on this one. Like I said I'm not 100% confident this configuration is exactly correct but it's as close as I can get it: I believe we need to try and see how it goes. If you have questions, let me know. cc @cpanato who seems to do a lot around here or I guess the tsc folks @bobcallaway @trevrosen @lukehinds @priyawadhwa @SantiagoTorres ? |
Yeah this looks fine, let's give it a shot and iterate as we need to. |
Can a TSC member merge this? |
Summary
Add new repository root-signing-staging, see #345 for details.
Fixes #345 (although further tweaks may be required: we'll see how the bot permissions match what tuf-on-ci expects, and what is needed to configure Pages publishing from GH actions).