Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

root-signing-staging: Update branch protection #450

Merged

Conversation

jku
Copy link
Member

@jku jku commented May 24, 2024

The intention is that both "publish" and "main" branches can be pushed to by sigstore-bot. Currently this is not true for "publish" (although somehow it was until yesterday?)

Copy the settings so "publish" has the same ones as "main".

This fixes #449, should unblock sigstore/root-signing-staging#130. Note that I'm not sure why the issue appears now but I think it has to do with the pulumi issues we were having...

CC @kommendorkapten @haydentherapper

The intention is that both "publish" and "main" branches can be pushed
to by sigstore-bot. Currently this is not true for "publish".

Copy the settings so "publish" has the same ones as "main".

Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
@jku jku requested a review from a team as a code owner May 24, 2024 13:10
Copy link

🍹 preview on sigstore-github-sync/sigstore/github-prod

Pulumi report
Previewing update (sigstore/github-prod)

View Live: https://app.pulumi.com/sigstore/sigstore-github-sync/github-prod/previews/ff14631d-eb6c-4a55-aa3c-b0f4c3a14a0e

@ Previewing update....
pulumi:pulumi:Stack: (same)
[urn=urn:pulumi:github-prod::sigstore-github-sync::pulumi:pulumi:Stack::sigstore-github-sync-github-prod]
@ Previewing update....
~ github:index/branchProtection:BranchProtection: (update)
    [id=BPR_kwDOKlCAEM4DA1SY]
    [urn=urn:pulumi:github-prod::sigstore-github-sync::github:index/branchProtection:BranchProtection::root-signing-staging-publish]
    [provider=urn:pulumi:github-prod::sigstore-github-sync::pulumi:providers:github::default_6_2_0::25aae923-754e-438f-8fef-788921b75628]
  ~ requiredPullRequestReviews: [
      ~ [0]: {
              ~ dismissalRestrictions: [
                  + [0]: "T_kwDOBDzYIc4AhiMd"
                ]
              ~ pullRequestBypassers : [
                  + [0]: "MDQ6VXNlcjg2ODM3MzY5"
                ]
            }
    ]
Resources:
~ 1 to update
586 unchanged

@jku
Copy link
Member Author

jku commented May 27, 2024

I'll do this change manually since I seem to have the permissions: this PR is still relevant but not urgent

@haydentherapper
Copy link
Contributor

@bobcallaway could this be a side effect of the manual branch protection changes we made to get syncing working again?

@bobcallaway
Copy link
Member

@bobcallaway could this be a side effect of the manual branch protection changes we made to get syncing working again?

yes, totally possible.

@bobcallaway bobcallaway merged commit 72e862b into sigstore:main May 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

root-signing-staging branch protection changed
4 participants