Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows Unit Test Flake #1389

Closed
dlorenc opened this issue Feb 2, 2022 · 3 comments
Closed

Windows Unit Test Flake #1389

dlorenc opened this issue Feb 2, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@dlorenc
Copy link
Member

dlorenc commented Feb 2, 2022

This has been failing about 30% of the time for a week or so now and passing on re-runs: https://github.com/sigstore/cosign/runs/5035173302?check_suite_focus=true

--- FAIL: TestReadWrite (0.06s)
    write_test.go:36: appending signatures: error writing layer: rename C:\Users\RUNNER~1\AppData\Local\Temp\TestReadWrite1396159366\001\blobs\sha256\e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b8553085564288 C:\Users\RUNNER~1\AppData\Local\Temp\TestReadWrite1396159366\001\blobs\sha256\e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855: Access is denied.
@haydentherapper
Copy link
Contributor

Is there any parallelization with the tests? Could one be removing a file while another tries to read/rename that deleted file?

@dekkagaijin
Copy link
Member

I remember Windows not playing nice with atomic writes (i.e. file renames). It may not be possible in a friendly way, though in this case we may be able to succeed on failure

@dlorenc
Copy link
Member Author

dlorenc commented Feb 6, 2022

I don't think it's parallelism, and I don't have a Windows machine to test with available. It looks like the error is actually coming from ggcr's test registry. I propose we just open the bug over there and skip this test in Windows untill it's narrowed down in the dependency.

dlorenc added a commit to dlorenc/cosign that referenced this issue Feb 7, 2022
See sigstore#1389

Signed-off-by: Dan Lorenc <lorenc.d@gmail.com>
dlorenc added a commit that referenced this issue Feb 8, 2022
See #1389

Signed-off-by: Dan Lorenc <lorenc.d@gmail.com>
@dlorenc dlorenc closed this as completed Feb 18, 2022
hatmarch pushed a commit to hatmarch/cosign that referenced this issue Apr 19, 2022
See sigstore#1389

Signed-off-by: Dan Lorenc <lorenc.d@gmail.com>
mlieberman85 pushed a commit to mlieberman85/cosign that referenced this issue May 6, 2022
See sigstore#1389

Signed-off-by: Dan Lorenc <lorenc.d@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants