-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use lowercase imageRef since docker does not support capital letters #1408
Labels
bug
Something isn't working
Comments
bobcallaway
added a commit
to bobcallaway/cosign
that referenced
this issue
Feb 6, 2022
Fixes: sigstore#1408 Signed-off-by: Bob Callaway <bob.callaway@gmail.com>
cc @mattmoor @jonjohnsonjr I thought we saw this back in December and fixed it in ggcr somewhere... |
We didn’t because the starter action uses some metadata action to normalize instead |
Ah whoops! |
dlorenc
pushed a commit
that referenced
this issue
Feb 7, 2022
Fixes: #1408 Signed-off-by: Bob Callaway <bob.callaway@gmail.com>
hatmarch
pushed a commit
to hatmarch/cosign
that referenced
this issue
Apr 19, 2022
Fixes: sigstore#1408 Signed-off-by: Bob Callaway <bob.callaway@gmail.com>
Ender-events
added a commit
to Ender-events/self-host-backup
that referenced
this issue
Apr 30, 2022
mlieberman85
pushed a commit
to mlieberman85/cosign
that referenced
this issue
May 6, 2022
Fixes: sigstore#1408 Signed-off-by: Bob Callaway <bob.callaway@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Per issue reported in sigstore/cosign-installer, docker push doesn't support references with uppercase characters.
There isn't really a useful error message to assist in debugging.
We can either check for uppercase characters and fail with a helpful error message, or we could transform the image ref to be in all lowercase characters before pushing the signature.
The text was updated successfully, but these errors were encountered: