Hardware Tokens doc missing subcommand piv-tool #1849
Labels
bug
Something isn't working
Comments
nealmcb
added a commit
to nealmcb/cosign
that referenced
this issue
May 6, 2022
[cosign/TOKENS\.md at main · sigstore/cosign](https://github.com/sigstore/cosign/blob/main/TOKENS.md) says: ... *run the* `cosign generate-key` *command* ... Which yields this error: ``` $ cosign generate-key Error: unknown command "generate-key" for "cosign" ``` The documentation is simply missing the `piv-tool` sub-command. Resolves: sigstore#1849 Signed-off-by: Neal McBurnett <neal@mcburnett.org>
nealmcb
added a commit
to nealmcb/cosign
that referenced
this issue
May 7, 2022
[cosign/TOKENS\.md at main · sigstore/cosign](https://github.com/sigstore/cosign/blob/main/TOKENS.md) says: ... *run the* `cosign generate-key` *command* ... Which yields this error: ``` $ cosign generate-key Error: unknown command "generate-key" for "cosign" ``` The documentation is simply missing the `piv-tool` sub-command. Resolves: sigstore#1849 Also fix make target for custom build: was make cosign-pivkey now make cosign-pivkey-pkcs11key. Drop old, brittle reference to line in Makefile. Signed-off-by: Neal McBurnett <neal@mcburnett.org>
|
Proceeding step-by-step, we see that there is also an obsolete Makefilie target being used in the doc. A fix for that is now also included in the PR. |
nealmcb
added a commit
to nealmcb/cosign
that referenced
this issue
May 7, 2022
[cosign/TOKENS\.md at main · sigstore/cosign](https://github.com/sigstore/cosign/blob/main/TOKENS.md) says: ... *run the* `cosign generate-key` *command* ... Which yields this error: ``` $ cosign generate-key Error: unknown command "generate-key" for "cosign" ``` The documentation is simply missing the `piv-tool` sub-command. Resolves: sigstore#1849 Also fix make target for custom build: was make cosign-pivkey now make cosign-pivkey-pkcs11key. Drop old, brittle reference to line in Makefile. Also note need to `cd cmd/cosign`. See also: sigstore#1853 Signed-off-by: Neal McBurnett <neal@mcburnett.org>
nealmcb
added a commit
to nealmcb/cosign
that referenced
this issue
May 7, 2022
[cosign/TOKENS\.md at main · sigstore/cosign](https://github.com/sigstore/cosign/blob/main/TOKENS.md) says: ... *run the* `cosign generate-key` *command* ... Which yields this error: ``` $ cosign generate-key Error: unknown command "generate-key" for "cosign" ``` The documentation is simply missing the `piv-tool` sub-command. Resolves: sigstore#1849 Also fix make target for custom build: was make cosign-pivkey now make cosign-pivkey-pkcs11key. Drop old, brittle reference to line in Makefile. Also make `go build` also work the same way, from the root directory. See also: sigstore#1853 Signed-off-by: Neal McBurnett <neal@mcburnett.org>
dlorenc
pushed a commit
that referenced
this issue
May 7, 2022
[cosign/TOKENS\.md at main · sigstore/cosign](https://github.com/sigstore/cosign/blob/main/TOKENS.md) says: ... *run the* `cosign generate-key` *command* ... Which yields this error: ``` $ cosign generate-key Error: unknown command "generate-key" for "cosign" ``` The documentation is simply missing the `piv-tool` sub-command. Resolves: #1849 Also fix make target for custom build: was make cosign-pivkey now make cosign-pivkey-pkcs11key. Drop old, brittle reference to line in Makefile. Also make `go build` also work the same way, from the root directory. See also: #1853 Signed-off-by: Neal McBurnett <neal@mcburnett.org>
pxp928
pushed a commit
to pxp928/cosign
that referenced
this issue
May 12, 2022
[cosign/TOKENS\.md at main · sigstore/cosign](https://github.com/sigstore/cosign/blob/main/TOKENS.md) says: ... *run the* `cosign generate-key` *command* ... Which yields this error: ``` $ cosign generate-key Error: unknown command "generate-key" for "cosign" ``` The documentation is simply missing the `piv-tool` sub-command. Resolves: sigstore#1849 Also fix make target for custom build: was make cosign-pivkey now make cosign-pivkey-pkcs11key. Drop old, brittle reference to line in Makefile. Also make `go build` also work the same way, from the root directory. See also: sigstore#1853 Signed-off-by: Neal McBurnett <neal@mcburnett.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
cosign/TOKENS.md at main · sigstore/cosign says:
... run the
cosign generate-keycommand ...Which yields this error:
The documentation is simply missing the
piv-toolsub-command.The text was updated successfully, but these errors were encountered: