Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean and copy commands only handle signatures #700

Closed
mattmoor opened this issue Sep 17, 2021 · 4 comments · Fixed by #1493
Closed

clean and copy commands only handle signatures #700

mattmoor opened this issue Sep 17, 2021 · 4 comments · Fixed by #1493
Assignees
@developer-guy

Comments

@mattmoor
Copy link
Member

Description

I think these should probably handle .att (attestations) as well.

Clean:

cosign/cmd/cosign/cli/clean.go

Line 59 in a868d65

sigRef, err := AttachedImageTag(ref, cosign.SignatureTagSuffix, remoteOpts...)

Copy:

cosign/cmd/cosign/cli/copy.go

Line 75 in a868d65

sigSrcRef, err := AttachedImageTag(srcRef, cosign.SignatureTagSuffix, remoteOpts...)

@dlorenc
Copy link
Member

dlorenc commented Sep 17, 2021

Yup! We discussed this here I think: #618. Not sure if anyone is working on it.

@dlorenc
Copy link
Member

dlorenc commented Feb 21, 2022

Clean now handles the rest, not sure about copy. cc @developer-guy

@developer-guy
Copy link
Member

yeah that's right @dlorenc, here is a PR for the clean command to support other types (attestations, sboms.)

#1430

Let's do the same for copy 🤩

@developer-guy developer-guy self-assigned this Feb 22, 2022
developer-guy added a commit to developer-guy/cosign that referenced this issue Feb 22, 2022
@developer-guy
feat: support other types in copy cmd
2d67f2f 
Fixes sigstore#700

Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com>
@developer-guy developer-guy mentioned this issue Feb 22, 2022
Merged
@developer-guy
Copy link
Member

#1430
#1493

both above will this issue.

dlorenc pushed a commit that referenced this issue Feb 22, 2022
@developer-guy
feat: support other types in copy cmd (#1493)
70d4cce 
Fixes #700

Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com>
hatmarch pushed a commit to hatmarch/cosign that referenced this issue Apr 19, 2022
@developer-guy
feat: support other types in copy cmd (sigstore#1493)
48ef7c6 
Fixes sigstore#700

Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com>
mlieberman85 pushed a commit to mlieberman85/cosign that referenced this issue May 6, 2022
@developer-guy @mlieberman85
feat: support other types in copy cmd (sigstore#1493)
4b6a049 
Fixes sigstore#700

Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@developer-guy developer-guy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: support other types in copy cmd developer-guy/cosign
3 participants
@dlorenc @mattmoor @developer-guy