Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider separating Signature vs. Attestation at the Interface level. #931

Open
vaikas opened this issue Oct 20, 2021 · 2 comments
Open
Labels
enhancement New feature or request

Comments

@vaikas
Copy link
Contributor

vaikas commented Oct 20, 2021

Description
As I was ramping up on #930 and #919 I found it a bit confusing that both Signature and Attestation are treated as Signature, even though they actually behave differently. I tried to clarify in the documentation to hopefully help other newcomers (or maybe it was just me :) ) but that led me to think that given that since there are some codepaths where these are treated differently in the code if we might want to consider separating the Interface as well. Just a thought.

@vaikas vaikas added the enhancement New feature or request label Oct 20, 2021
@mattmoor
Copy link
Member

Yeah, I'm +1 on this. I'd hope to reach this point with #666 but was concerned that it would require divergence in signing and verification flows. Given the bugs we found (and you are fixing) I'm thinking that having them shared is more trouble (and confusion) than it is worth.

I think having Signature which carries the signature annotations, and Attestation, which is more strongly oriented around DSSE and does not (the payload is the signature).

cc @dekkagaijin @dlorenc

@dlorenc
Copy link
Member

dlorenc commented Oct 20, 2021

+1, a Verifiable (?) interface could make sense. We could add support for other signature types as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants