refactoring signature logic #1065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dekkagaijin
force-pushed
the
sign-refacc
branch
from
a0a20ff
to
6680a1d
Compare
mattmoor
reviewed
Nov 18, 2021
mattmoor
reviewed
Nov 18, 2021
dekkagaijin
force-pushed
the
sign-refacc
branch
9 times, most recently
from
549781c
to
3bc3f19
Compare
added 3 commits
November 22, 2021 13:42
* factor out fulcio client generation * refactor SignerFromKeyOpts * fix lint error Signed-off-by: Jake Sanders <jsand@google.com>
Signed-off-by: Jake Sanders <jsand@google.com>
Signed-off-by: Jake Sanders <jsand@google.com>
dekkagaijin
force-pushed
the
sign-refacc
branch
from
821621c
to
d986e3c
Compare
mattmoor
approved these changes
Nov 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc #844 and #931