Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PKCS11: Fix certificate check #1041

Merged
merged 3 commits into from
Nov 12, 2021
Merged

PKCS11: Fix certificate check #1041

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4d15ff3
PKCS11: Fix certificate check
garantir-km Nov 12, 2021
89b15e2
Merge branch 'sigstore:main' into fix-pkcs11-no-cert
garantir-km Nov 12, 2021
d5df63f
Remove unused variable assignment
garantir-km Nov 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cmd/cosign/cli/sign/sign.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,9 +340,9 @@ func SignerFromKeyOpts(ctx context.Context, certPath string, ko KeyOpts) (*CertS
// user.
pkcs11Key, ok := k.(*pkcs11key.Key)
if ok {
certFromPKCS11, err := pkcs11Key.Certificate()
certFromPKCS11, _ := pkcs11Key.Certificate()
var pemBytes []byte
if err != nil {
if certFromPKCS11 == nil {
fmt.Fprintln(os.Stderr, "warning: no x509 certificate retrieved from the PKCS11 token")
} else {
pemBytes, err = cryptoutils.MarshalCertificateToPEM(certFromPKCS11)
Expand Down