Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split private signature and attestation verification fns #1043

Merged
merged 1 commit into from
Nov 12, 2021

Conversation

dekkagaijin
Copy link
Member

NONE

Signed-off-by: Jake Sanders <jsand@google.com>
if err != nil {
return err
}
verifier = newReverseDSSEVerifier(verifier)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we even still need this? Can it be simplified?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it can be simplified, will continue in a subsequent PR

@dekkagaijin dekkagaijin merged commit 6ed55d6 into sigstore:main Nov 12, 2021
@github-actions github-actions bot added this to the v1.4.0 milestone Nov 12, 2021
@dekkagaijin dekkagaijin deleted the verify branch November 12, 2021 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants