Drop strfmt.Base64 from pkg/oci.
#1083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imjasonh
approved these changes
Nov 19, 2021
I noticed that vendoring `pkg/oci` was pulling in stuff from `mongodb`, and pulling the thread it seems to come from this line. `Base64` is an alias of `[]byte`, so this should have a relatively low migration cost. Signed-off-by: Matt Moore <mattmoor@chainguard.dev>
mattmoor
force-pushed
the
drop-strfmt
branch
from
4238852
to
6089e42
Compare
dlorenc
approved these changes
Nov 19, 2021
|
Ok I lied, I was expecting build failures, so I passed |
Signed-off-by: Matt Moore <mattmoor@chainguard.dev>
|
LOL we also had a place where we were casting to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that vendoring
pkg/ociwas pulling in stuff frommongodb, and pulling the thread it seems to come from this line.Base64is an alias of[]byte, and changing it seems to break nothing, so great!Signed-off-by: Matt Moore mattmoor@chainguard.dev
Ticket Link
Release Note