Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor attestation logic into cosign.Attestor #1124

Closed
wants to merge 9 commits into from
Closed

refactor attestation logic into cosign.Attestor #1124

wants to merge 9 commits into from

Commits on Dec 2, 2021

  1. refactor attestation logic into cosign.Attestor 

    Signed-off-by: Jake Sanders <jsand@google.com>
    Jake Sanders committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    a732bdf View commit details
    Browse the repository at this point in the history

  2. add TODO to refactor signer creation 

    Signed-off-by: Jake Sanders <jsand@google.com>
    Jake Sanders committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    6d5eac4 View commit details
    Browse the repository at this point in the history

  3. add tests for internal/pkg/cosign/rekor/util.go 

    Signed-off-by: Jake Sanders <jsand@google.com>
    Jake Sanders committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    850ee49 View commit details
    Browse the repository at this point in the history

  4. update signer & attestor names 

    Signed-off-by: Jake Sanders <jsand@google.com>
    Jake Sanders committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    e3fde8c View commit details
    Browse the repository at this point in the history

  5. return error from call to attest 

    Signed-off-by: Jake Sanders <jsand@google.com>
    Jake Sanders committed Dec 2, 2021
    Configuration menu
    Copy the full SHA
    6458dd7 View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2021

  1. split payload Signer and Attestor into distinct files 

    Signed-off-by: Jake Sanders <jsand@google.com>
    Jake Sanders committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    113576d View commit details
    Browse the repository at this point in the history

  2. formatting nit 

    Signed-off-by: Jake Sanders <jsand@google.com>
    Jake Sanders committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    2e87090 View commit details
    Browse the repository at this point in the history

  3. touch up comments 

    Signed-off-by: Jake Sanders <jsand@google.com>
    Jake Sanders committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    3b79608 View commit details
    Browse the repository at this point in the history

  4. fix test case formatting 

    Signed-off-by: Jake Sanders <jsand@google.com>
    Jake Sanders committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    6aca520 View commit details
    Browse the repository at this point in the history