Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to verify attestations from local image #1174

Merged
merged 1 commit into from
Dec 9, 2021
Merged

Add option to verify attestations from local image #1174

merged 1 commit into from
Dec 9, 2021

Conversation

haydentherapper
Copy link
Contributor

@haydentherapper haydentherapper commented Dec 8, 2021 •
edited
Loading

This is very similar to a previous PR (#1159) that added support for verifying signatures from a local image.

Ref #1015

Example:

...generate attestation...
cosign save us-west1-docker.pkg.dev/project/docker-repo/image:tag1 --dir .
cosign verify-attestation --key cosign.pub --local-image . --verbose

With --verbose, we see no network calls.

Signed-off-by: Hayden Blauzvern hblauzvern@google.com

Release Note

Add `cosign verify-attestation --local-image path` for verifying signed images with attestations from disk

@haydentherapper
Copy link
Contributor Author

cc @priyawadhwa

priyawadhwa
priyawadhwa approved these changes Dec 8, 2021
View reviewed changes
Copy link
Contributor

@priyawadhwa priyawadhwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one nit, lgtm!

cmd/cosign/cli/options/verify.go Outdated Show resolved Hide resolved
@haydentherapper
Add option to verify attestations from local image
1a073ed 
This is very similar to a previous commit that added
support for verifying signatures from a local image.

Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
@dlorenc dlorenc merged commit 5a5914f into sigstore:main Dec 9, 2021
@github-actions github-actions bot added this to the v1.4.1 milestone Dec 9, 2021
@haydentherapper haydentherapper deleted the verify-attest-local branch December 9, 2021 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@priyawadhwa priyawadhwa priyawadhwa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.4.1
Development

Successfully merging this pull request may close these issues.
3 participants
@haydentherapper @priyawadhwa @dlorenc