-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --bundle flag to sign-blob and verify-blob #1306
Conversation
Signed-off-by: Priya Wadhwa <priyawadhwa@google.com>
b9f91da
to
566ff3b
Compare
For #1294, we're going to include a TUF timestamp in the OCI signature. Will this automatically pick this up, or will we need to append the timestamp to the bundle? |
I'd be fine adding it by default now - this is only relevant for the |
@haydentherapper I think it'll need to be added in, I can update that! @dlorenc it should work for all workflows right now (for the regular workflow it'll just store the signature in the file and nothing else). Should we only do it for experimental right now? |
Thanks @priyawadhwa! #1294 has been merged. You should just need to add |
Signed-off-by: Priya Wadhwa <priyawadhwa@google.com>
73c5710
to
f5ef32f
Compare
Signed-off-by: Priya Wadhwa <priyawadhwa@google.com>
* Add --bundle flag to sign-blob and verify-blob Signed-off-by: Priya Wadhwa <priyawadhwa@google.com> * Add TUF timestamp when signing Signed-off-by: Priya Wadhwa <priyawadhwa@google.com>
Add in
--bundle
flag tocosign sign-blob
andcosign verify-blob
. The bundle stores everything required to verify a blob in a file, so now you can do something like this:The bundle is basically just JSON with the Signature, Cert, and RekorBundle included.
Some thoughts I had, which might be future work:
--bundle
flag, but later we might wantsign-blob
to print out the entire bundle instead of just the signature by default--bundle
, but later we might want certain flags to work together (e.g.--b64
)fixes #1193