-
Notifications
You must be signed in to change notification settings - Fork 547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump recommended Go development version in README #1340
Conversation
CI only runs tests on 1.17 (it still runs *builds* on 1.16, so the other references in the README are fine). Further, builds *are* broken on 1.16 right now. Signed-off-by: Zachary Newman <z@znewman.net>
@@ -30,7 +30,7 @@ For Linux and macOS binaries see the [GitHub release assets](https://github.com/ | |||
|
|||
## Developer Installation | |||
|
|||
If you have Go 1.16+, you can setup a development environment: | |||
If you have Go 1.17+, you can setup a development environment: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not an expert on Go modules but AFAICT the Go version in go.mod
has 2 effects:
- Restricts language features introduced after that version.
- Changes the behavior of the
go
command. In particular, for the 1.16->1.17 transition the consequential changes:- starts including explicit
requires
ingo.mod
for transitive dependencies - vendoring acts a little different (starts recording dependencies' Go versions from
go.mod
, omitsgo.mod
andgo.sum
for vendored dependencies)
- starts including explicit
Because as of right now we still want to support 1.16, my initial thought is that (1) is a good thing for development and I'm inclined not to change it. Of course, will defer to you all :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We chatted about bumping the other one to 1.17 soon, this one seems fine as is and we can do the other one later.
@@ -30,7 +30,7 @@ For Linux and macOS binaries see the [GitHub release assets](https://github.com/ | |||
|
|||
## Developer Installation | |||
|
|||
If you have Go 1.16+, you can setup a development environment: | |||
If you have Go 1.17+, you can setup a development environment: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We chatted about bumping the other one to 1.17 soon, this one seems fine as is and we can do the other one later.
CI only runs tests on 1.17 (it still runs *builds* on 1.16, so the other references in the README are fine). Further, builds *are* broken on 1.16 right now. Signed-off-by: Zachary Newman <z@znewman.net>
Summary
#568 bumps the Go version for tests to 1.17. Now they break for 1.16:
#1252 adds a call to
testing.T.Setenv
, added in 1.17, which caused this breakage.(We're still testing builds on 1.16, so that's fine.)
Ticket Link
Fixes N/A
Release Note