convert release cosigned to also generate yaml artifact. #1453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kenny Leung <kleung@chainguard.dev>
|
@cpanato one thing I'm not sure is whether all the artifacts listed in the cloudbuild.yaml will be included in the release or is there another step to it. can you please let me know if it is the case or not. thank you. |
dlorenc
approved these changes
Feb 15, 2022
|
sorry for the delay, missed this notification |
cpanato
approved these changes
Feb 15, 2022
|
I only added this for cosigned and not cosign or sget as there are no yamls associated with those.
|
cpanato
pushed a commit
to cpanato/cosign
that referenced
this pull request
Feb 18, 2022
Signed-off-by: Kenny Leung <kleung@chainguard.dev>
cpanato
pushed a commit
to cpanato/cosign
that referenced
this pull request
Feb 18, 2022
Signed-off-by: Kenny Leung <kleung@chainguard.dev> Signed-off-by: Carlos Panato <ctadeu@gmail.com>
cpanato
added a commit
that referenced
this pull request
Feb 18, 2022
* update cross-build to use go 1.17.7 (#1446) Signed-off-by: Carlos Panato <ctadeu@gmail.com> * update cross-build to use go 1.17.7 (#1446) Signed-off-by: Carlos Panato <ctadeu@gmail.com> * convert release cosigned to also generate yaml artifact. (#1453) Signed-off-by: Kenny Leung <kleung@chainguard.dev> Signed-off-by: Carlos Panato <ctadeu@gmail.com> * Double goreleaser timeout (#1472) Fixes (hopefully) #1471 Signed-off-by: Zachary Newman <z@znewman.net> Signed-off-by: Carlos Panato <ctadeu@gmail.com> * increase timeout for goreleaser snapshot (#1473) Signed-off-by: Carlos Panato <ctadeu@gmail.com> * refactor release cloudbuild job (#1476) Signed-off-by: Carlos Panato <ctadeu@gmail.com> Co-authored-by: Kenny Leung <k4leung4@gmail.com> Co-authored-by: Zack Newman <z@znewman.net>
mlieberman85
pushed a commit
to mlieberman85/cosign
that referenced
this pull request
May 6, 2022
Signed-off-by: Kenny Leung <kleung@chainguard.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
After advise from @cpanato , updated the existing cloud build to generate a yaml artifact for the cosigned webhook instead of the standalone github action. This ensure that the image is built the same way as other artifacts.
This makes #1436 obsolete.
Ticket Link
Fixes
#1414
Release Note
Signed-off-by: Kenny Leung kleung@chainguard.dev