Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

images: remove --bare flags that conflict with --base-import-paths #1533

Merged
merged 1 commit into from
Mar 2, 2022

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Mar 2, 2022

Summary

  • images: remove --bare flags that conflict with --base-import-paths
    if use both the --base-import-paths take precedence, so removing --bare

Ticket Link

Fixes

Release Note

NONE

@codecov-commenter
Copy link

codecov-commenter commented Mar 2, 2022

Codecov Report

Merging #1533 (d1a4d08) into main (f1c0b71) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1533      +/-   ##
==========================================
- Coverage   26.49%   26.44%   -0.05%     
==========================================
  Files         126      126              
  Lines        7214     7214              
==========================================
- Hits         1911     1908       -3     
- Misses       5093     5095       +2     
- Partials      210      211       +1     
Impacted Files Coverage Δ
pkg/cosign/tuf/client.go 62.34% <0.00%> (-0.95%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1c0b71...d1a4d08. Read the comment docs.

@cpanato cpanato requested review from dlorenc and mattmoor March 2, 2022 12:29
@dlorenc dlorenc merged commit 73235ac into sigstore:main Mar 2, 2022
@github-actions github-actions bot added this to the v1.6.0 milestone Mar 2, 2022
@cpanato cpanato deleted the update-ko-flags branch March 2, 2022 13:41
mlieberman85 pushed a commit to mlieberman85/cosign that referenced this pull request May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants