Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkcs11: fix build instructions #1550

Merged
merged 1 commit into from
Mar 4, 2022
Merged

Conversation

rgerganov
Copy link
Contributor

The build target for pkcs11 has been renamed from 'cosign-pkcs11key' to
'cosign-pivkey-pkcs11key' with commit d673477.

Signed-off-by: Radoslav Gerganov rgerganov@vmware.com

The build target for pkcs11 has been renamed from 'cosign-pkcs11key' to
'cosign-pivkey-pkcs11key' with commit d673477.

Signed-off-by: Radoslav Gerganov <rgerganov@vmware.com>
@codecov-commenter
Copy link

codecov-commenter commented Mar 4, 2022

Codecov Report

Merging #1550 (cb308b0) into main (4b2c3c0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1550   +/-   ##
=======================================
  Coverage   26.49%   26.49%           
=======================================
  Files         126      126           
  Lines        7214     7214           
=======================================
  Hits         1911     1911           
  Misses       5093     5093           
  Partials      210      210           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b2c3c0...cb308b0. Read the comment docs.

Copy link
Contributor

@hectorj2f hectorj2f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dlorenc dlorenc merged commit 9edd96f into sigstore:main Mar 4, 2022
@github-actions github-actions bot added this to the v1.7.0 milestone Mar 4, 2022
mlieberman85 pushed a commit to mlieberman85/cosign that referenced this pull request May 6, 2022
The build target for pkcs11 has been renamed from 'cosign-pkcs11key' to
'cosign-pivkey-pkcs11key' with commit d673477.

Signed-off-by: Radoslav Gerganov <rgerganov@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants