Add public key validation #1598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kavitha Krishnan <krishnanka@vmware.com>
Codecov Report
@@ Coverage Diff @@
## main #1598 +/- ##
==========================================
+ Coverage 27.44% 27.96% +0.51%
==========================================
Files 137 137
Lines 7742 7789 +47
==========================================
+ Hits 2125 2178 +53
+ Misses 5387 5383 -4
+ Partials 230 228 -2
Continue to review full report at Codecov.
|
coyote240
approved these changes
Mar 11, 2022
Signed-off-by: hectorj2f <hectorf@vmware.com>
hectorj2f
force-pushed
the
1596-validate-pubkey
branch
from
f533078 to
7573633
Compare
Signed-off-by: hectorj2f <hectorf@vmware.com>
hectorj2f
force-pushed
the
1596-validate-pubkey
branch
from
7573633 to
9c359f6
Compare
hectorj2f
reviewed
Mar 13, 2022
| @@ -21,8 +21,6 @@ spec: | |||
| - glob: images.* | |||
| - glob: image* | |||
| authorities: | |||
| - key: | |||
| data: "---another-public-key---" | |||
| - keyless: | |||
There was a problem hiding this comment.
I removed another-public-key and fixed the code validating the key.
hectorj2f
approved these changes
Mar 13, 2022
dlorenc
approved these changes
Mar 13, 2022
|
Nice work! |
mlieberman85
pushed a commit
to mlieberman85/cosign
that referenced
this pull request
May 6, 2022
* Add public key validation Signed-off-by: Kavitha Krishnan <krishnanka@vmware.com> * fix: key validation Signed-off-by: hectorj2f <hectorf@vmware.com> * fix: test valid policy using wrong key data Signed-off-by: hectorj2f <hectorf@vmware.com> Co-authored-by: hectorj2f <hectorf@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kavitha Krishnan krishnanka@vmware.com
Sets util func for part of : #1596
cc: @vaikas @coyote240