FUN.md broke when RecordObj changed to HashedRecordObj #1633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MitchellJThomas please sign the DCO, thanks for this update! |
The breakage occured sometime on or before version 1.6 I found it when running this version: GitVersion: 1.6.0 GitCommit: 4b2c3c0 GitTreeState: "clean" BuildDate: 2022-03-03T17:59:06Z GoVersion: go1.17.8 Compiler: gc Platform: darwin/amd64 Signed-off-by: Mitch Thomas <mitch.thomas@gmail.com>
Done. You are welcome. |
- OpenSSF Best Practices Badge 94% Signed-off-by: naveensrinivasan <172697+naveensrinivasan@users.noreply.github.com> Signed-off-by: Mitch Thomas <mitch.thomas@gmail.com>
The breakage occured sometime on or before version 1.6 I found it when running this version: GitVersion: 1.6.0 GitCommit: 4b2c3c0 GitTreeState: "clean" BuildDate: 2022-03-03T17:59:06Z GoVersion: go1.17.8 Compiler: gc Platform: darwin/amd64 Signed-off-by: Mitch Thomas <mitch.thomas@gmail.com>
|
Seems I kinda goofed with the |
Codecov Report
@@ Coverage Diff @@
## main #1633 +/- ##
=======================================
Coverage 27.97% 27.97%
=======================================
Files 137 137
Lines 7820 7820
=======================================
Hits 2188 2188
Misses 5403 5403
Partials 229 229 Continue to review full report at Codecov.
|
dlorenc
approved these changes
Mar 19, 2022
|
Theres a weird e2e flake that looks to be an internal github error, but this is a doc only change so I'm not going to retry it. |
mlieberman85
pushed a commit
to mlieberman85/cosign
that referenced
this pull request
May 6, 2022
* FUN.md broke when RecordObj changed to HashedRecordObj The breakage occured sometime on or before version 1.6 I found it when running this version: GitVersion: 1.6.0 GitCommit: 4b2c3c0 GitTreeState: "clean" BuildDate: 2022-03-03T17:59:06Z GoVersion: go1.17.8 Compiler: gc Platform: darwin/amd64 Signed-off-by: Mitch Thomas <mitch.thomas@gmail.com> * Included OpenSSF Best Practices Badge (sigstore#1628) - OpenSSF Best Practices Badge 94% Signed-off-by: naveensrinivasan <172697+naveensrinivasan@users.noreply.github.com> Signed-off-by: Mitch Thomas <mitch.thomas@gmail.com> * FUN.md broke when RecordObj changed to HashedRecordObj The breakage occured sometime on or before version 1.6 I found it when running this version: GitVersion: 1.6.0 GitCommit: 4b2c3c0 GitTreeState: "clean" BuildDate: 2022-03-03T17:59:06Z GoVersion: go1.17.8 Compiler: gc Platform: darwin/amd64 Signed-off-by: Mitch Thomas <mitch.thomas@gmail.com> Co-authored-by: Naveen <172697+naveensrinivasan@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The breakage occurred sometime on or before version 1.6
This is a proposed fix for issue #1632
Note: the proposed commit is signed using Level 11 (yes!)
Summary
Switch the jq command to use the HashedRecordObj value
Release Note